Code review is one of the highest-leverage activities in software development. Here's how to do it well.
Early in my career, I dreaded code reviews. They felt like judgment—a senior engineer picking apart my work, leaving comments about variable names and missing semicolons.
Now I see code review differently: it's a conversation about the future of the codebase, a teaching moment, and a safety net all rolled into one.
What to look for:
1. Correctness - Does the code do what it's supposed to do? 2. Design - Is this the right approach? Will it scale? 3. Readability - Can someone else understand this in six months? 4. Edge cases - What happens when things go wrong?
How to give feedback:
- Ask questions instead of making demands - Explain the 'why' behind suggestions - Distinguish between blockers and preferences - Acknowledge what's done well
The best code reviews I've received taught me something. The best code reviews I've given started conversations that improved the whole team's understanding.